[FFmpeg-devel] [PATCH]Show mxf Universal Label with loglevel verbose

Dave Rice dave at dericed.com
Tue Feb 12 01:53:11 CET 2013


On Feb 11, 2013, at 9:53 AM, Tim Nicholson <nichot20 at yahoo.com> wrote:

> On 11/02/13 12:14, Carl Eugen Hoyos wrote:
>> Tomas Härdin <tomas.hardin <at> codemill.se> writes:
>> 
>>>>         st->codec->codec_id = (enum AVCodecID)codec_ul->id;
>>>> +        av_log(mxf->fc, AV_LOG_VERBOSE, "%s: Universal Label: 0x",
>>>> +               avcodec_get_name(st->codec->codec_id));
>>> 
>>> Do we need the "0x"?
>> 
>> Pushed without "0x".
>> If the SMPTE standard notation is needed (I don't know), 
>> it should be easy to change the code.
>> 
> 
> I think the SMPTE is a bit more readable as it helps identify the
> hierarchical tree.
> 
> Long strings of hex send me cross eyed....

I originally proposed a hex expression to keep the UL expression consistent with how ffmpeg express fourccs, but now agree that Tomas's suggestion of SMPTE's format is preferable.
Dave Rice


More information about the ffmpeg-devel mailing list