[FFmpeg-devel] [PATCH]Show mxf Universal Label with loglevel verbose

[Carl Eugen Hoyos]

On Monday 11 February 2013 11:28:33 am Tomas Härdin wrote:

> Do we need the "0x"? It's unstandard. I'd say go with the pure UL in
> unspaced hex or use the SMPTE standard notation (hex groups separated by
> dots). The latter looks like this (from
> http://www.freemxf.org/mxflib-docs/mxflib-1.0.0-docs/dict_8h-source.html):
>
>  060E2B34.0104.0101.01010500.00000000

Additional patch attached.

I will apply if you prefer it over the current variant.

Thank you, Carl Eugen
-------------- next part --------------
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index 21f9bba..f7aaa5a 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -1508,9 +1508,12 @@ static int mxf_parse_structural_metadata(MXFContext *mxf)
         st->codec->codec_id = (enum AVCodecID)codec_ul->id;
         av_log(mxf->fc, AV_LOG_VERBOSE, "%s: Universal Label: ",
                avcodec_get_name(st->codec->codec_id));
-        for (k = 0; k < 16; k++)
+        for (k = 0; k < 16; k++) {
             av_log(mxf->fc, AV_LOG_VERBOSE, "%.2x",
                    descriptor->essence_codec_ul[k]);
+            if (!(k+1 & 19) || k == 5)
+                av_log(mxf->fc, AV_LOG_VERBOSE, ".");
+        }
         av_log(mxf->fc, AV_LOG_VERBOSE, "\n");
         if (st->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
             source_track->intra_only = mxf_is_intra_only(descriptor);