[FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

Jan Ekstrom jeebjp at gmail.com
Mon Jan 4 00:13:47 CET 2016


Hi,

In general looks good, although it might look a bit weird for someone
as usually libraries have initialization functions called like that.
That said, this is what
https://gnupg.org/documentation/manuals/gcrypt/Initializing-the-library.html
recommends.

My only comment would be that we might want to set the parameter to
GCRYPT_VERSION instead of NULL, as we most probably care if the
library loaded matches our version (unless these versions change even
if API doesn't change).

Best regards,
Jan


More information about the ffmpeg-devel mailing list