[FFmpeg-devel] Fwd: [PATCH] avutil/frame: document data alignment restriction

Muhammad Faiz mfcc64 at gmail.com
Sat Jul 22 18:45:39 EEST 2017


On Sat, Jul 22, 2017 at 9:53 PM, Nicolas George <george at nsup.org> wrote:
> Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit :
>> It fixed the testcase's crash, but didn't fix the bug.
>
> So it is not FIXED.
>
>> It is easy for application:
>>    - always use av_frame_get_buffer
>>    - never modify audio data pointer.
>
> Even easier: never use libavcodec. Kind of defeating the purpose. The
> point of a library is to reduce the amount of code required by
> applications. By adding that constraint, you either restrict what the
> applications can do with the library or require more code from them.
> Both are bad, both should be avoided if possible. And in this particular
> case it is possible.

Of course, the linesize constraint has already been there. Should we
relax this constraint?
Also, generally FFmpeg's API is full of constraints.

>
>> On the contrary, handling unaligned data/linesize in the library is not easy.
>
> It is very easy, I have already implemented it. The patch is on the
> mailing-list since two months ago.

So, why did you stop working on this?
I just want to take an easier path.

Thank's.


More information about the ffmpeg-devel mailing list