[FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer

Michael Niedermayer michael at niedermayer.cc
Fri May 26 14:43:26 EEST 2017

On Fri, May 26, 2017 at 01:11:38PM +0200, Paul B Mahol wrote:
> On 5/26/17, Nicolas George <george at nsup.org> wrote:
> > Le septidi 7 prairial, an CCXXV, Paul B Mahol a ecrit :
> >> > This belongs in libswresample
> >> No it does not.
> >
> > I think it does too.
> You want to link libswresample with libavcodec?

While this question was directed at nicolas ...

I dont think audio upmix code should depend on a lib of encoders and
decoders (libavcodec)
No matter if the upmix code would be in libavfilter or libswresample

I belive a temporary dependancy would be ok, if there is intend to
factor/move things to remove the dependancy in the future.

But IMO libavcodec is the wrong place to export generic FFT
We need FFTs in codecs, we need them in filters, we need them in
swresample (the soxr resampler we support also uses a FFT internally)

Also moving FFT to a different lib should be quite easy compared to
other ugly dependancies we have (as in snow motion estimation, which
is not as easy to move. none the less none of these ugly dependancies
should be there except temporary)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170526/84f44351/attachment.sig>

More information about the ffmpeg-devel mailing list