[FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer
Paul B Mahol
onemda at gmail.com
Fri May 26 19:54:33 EEST 2017
On 5/26/17, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Fri, May 26, 2017 at 01:11:38PM +0200, Paul B Mahol wrote:
>> On 5/26/17, Nicolas George <george at nsup.org> wrote:
>> > Le septidi 7 prairial, an CCXXV, Paul B Mahol a ecrit :
>> >> > This belongs in libswresample
>> >> No it does not.
>> > I think it does too.
>> You want to link libswresample with libavcodec?
> While this question was directed at nicolas ...
> I dont think audio upmix code should depend on a lib of encoders and
> decoders (libavcodec)
> No matter if the upmix code would be in libavfilter or libswresample
> I belive a temporary dependancy would be ok, if there is intend to
> factor/move things to remove the dependancy in the future.
> But IMO libavcodec is the wrong place to export generic FFT
> We need FFTs in codecs, we need them in filters, we need them in
> swresample (the soxr resampler we support also uses a FFT internally)
> Also moving FFT to a different lib should be quite easy compared to
> other ugly dependancies we have (as in snow motion estimation, which
> is not as easy to move. none the less none of these ugly dependancies
> should be there except temporary)
This code does upmixing, and there could by myriad variants of upmixing.
Having it in libswresample is flawed design.
So I will not do the transitions.
If you still object to leave it as it is, in lavfi. You will need to take
care of the necessary changes by yourself.
More information about the ffmpeg-devel