[FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

[Rémi Denis-Courmont]

Le 4 février 2024 11:11:12 GMT+01:00, Marton Balint <cus at passwd.hu> a écrit :
>Actually they work here on a linux box with OpenSuse 15.5. So even if they
>are broken on some setups, they are not broken everywhere, or not more broken than they used to be.

No. They were always broken in terms of the design, and they are more technically broken than before because the threading rework exposed the design bugs from within fftools.

No sane application would use this. If it doesn't even work in fftools, it should be removed.

>Also, poper deprecation is needed here, since not only the CLI tools might use these. Especially since there is no drop-in replacement.

First it's not what would be considered an API. The removal shouldn't break source compatibility, so deprecation won't get us anything here. Where would you even put the deprecation guards?

And then deprecation only makes sense if it can be fixed. Nobody has come forward with a practical solution to make it work, probably because there is not one, at least on MacOS.

>> The 'pipe:' output can be used with a real video player such as mpv, vlc, or
>> even ffplay. For cases where the user was an application using the API they
>> should supply their own renderer.
>
>Yeah, but I never liked when people piped uncompressed data... Not everything that the devices support can be serialized, it is extra CPU, latency of the receiving app reading from pipe is a question...

That sounds pretty minor problems for something that's purely meant for testing, and well, at least piping works.

>I'd be a lot more happy with this if we'd offer some replacement which has no issues. Maybe a libplacebo based outdev.

That's orthogonal, and you're welcome to provide patches. But AFAICT, any video output device would suffer the same problems on the same platforms. You simply can't treat video output as a generic pipeline component, at least on Windows and especially MacOS.