[FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

[Marton Balint]

On Sun, 4 Feb 2024, Rémi Denis-Courmont wrote:

>
>
> Le 4 février 2024 11:11:12 GMT+01:00, Marton Balint <cus at passwd.hu> a écrit :
>> Actually they work here on a linux box with OpenSuse 15.5. So even if they
>> are broken on some setups, they are not broken everywhere, or not more broken than they used to be.
>
> No. They were always broken in terms of the design, and they are more technically broken than before because the threading rework exposed the design bugs from within fftools.
>
> No sane application would use this. If it doesn't even work in fftools, it should be removed.

As I wrote earlier, it works for me.

>
>> Also, poper deprecation is needed here, since not only the CLI tools might use these. Especially since there is no drop-in replacement.
>
> First it's not what would be considered an API. The removal shouldn't break source compatibility, so deprecation won't get us anything here. Where would you even put the deprecation guards?

See what Anton did with the BKTR device.

>
> And then deprecation only makes sense if it can be fixed. Nobody has come forward with a practical solution to make it work, probably because there is not one, at least on MacOS.

See Michael's suggestions with the thread safety flag.

Regards,
Marton