[FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis
Andreas Rheinhardt
andreas.rheinhardt at outlook.com
Thu Feb 29 13:52:58 EET 2024
Niklas Haas:
> + av_assert0(out_frame->format == in_frame->format);
You already asserted that generically at the start of
ff_aom_apply_film_grain().
> + if (in_frame->format != AV_PIX_FMT_YUV420P10LE)
> + return AVERROR_PATCHWELCOME;
wtf! This makes the whole code pointless on BE and makes the 8 bit
version pointless, too.
- Andreas
More information about the ffmpeg-devel
mailing list