[FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

[Niklas Haas]

On Thu, 29 Feb 2024 12:52:58 +0100 Andreas Rheinhardt <andreas.rheinhardt at outlook.com> wrote:
> Niklas Haas:
> > +    av_assert0(out_frame->format == in_frame->format);
> 
> You already asserted that generically at the start of
> ff_aom_apply_film_grain().

Fixed.

> > +    if (in_frame->format != AV_PIX_FMT_YUV420P10LE)
> > +        return AVERROR_PATCHWELCOME;
> 
> wtf! This makes the whole code pointless on BE and makes the 8 bit
> version pointless, too.

Yikes, this was clearly left over from before I made this code generic!
Fixed.

(Doesn't help that I have no other test files for this code..)