[FFmpeg-soc] [soc]: r1649 - qcelp/qcelpdec.c

Reynaldo Verdejo rverdejo at gmail.com
Sat Dec 22 23:36:04 CET 2007


Hi Diego
Hi Diego

On Dec 22, 2007 6:49 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, Dec 22, 2007 at 09:30:40PM +0100, reynaldo wrote:
> >
> > Log:
> > Removing ununsed var
>
> Remove unused var.
>
> I find using gerunds (-ing form) in commit messages rather awkward.  The
> connotation for me is that the action is still taking place, but
> obviously removing an unused variable is not a complex change that is
> not yet finished.

I don't like this form better than you do, I would have said 'Removes an
unused var' as I was used to but you claimed it was invalid some days ago.
I will need to do some thinking over this issue. Thanks for the hint though.

Reynaldo



More information about the FFmpeg-soc mailing list