[FFmpeg-soc] [soc]: r530 - matroska/matroskaenc.c

[David Conrad]

On Jul 25, 2007, at 8:46 PM, Michael Niedermayer wrote:

> Hi
>
> On Thu, Jul 26, 2007 at 02:05:30AM +0200, conrad wrote:
>> Author: conrad
>> Date: Thu Jul 26 02:05:30 2007
>> New Revision: 530
>>
>> Log:
>> Write the creation time
> [...]
>> @@ -526,6 +538,7 @@ static int mkv_write_header(AVFormatCont
>>      if (!(s->streams[0]->codec->flags & CODEC_FLAG_BITEXACT)) {
>>          put_ebml_string(pb, MATROSKA_ID_MUXINGAPP ,  
>> LIBAVFORMAT_IDENT);
>>          put_ebml_string(pb, MATROSKA_ID_WRITINGAPP,  
>> LIBAVFORMAT_IDENT);
>> +        put_ebml_date  (pb, MATROSKA_ID_DATEUTC   , av_gettime 
>> ()     );
>>      }
>
> storing the creation time in a file without the users knowledge is  
> a security
> risk
> an example would be a journalist who recorded a film of some  
> officials in
> [put your favorite dictatorship here] killing/tourturing some people
> and encodes that and stores it in a mkv and then uploads it somewhere
> knowing the time when the mkv was created is a large part of whats  
> needed for
> the officials to identify and eliminate him (the missing part is  
> where the
> encoding happened and who was there at that time or even just where  
> was
> suspect X at that time ...)

Okay, I've reverted this. I don't think it's worth adding an option  
to toggle it.