[FFmpeg-trac] #8156(undetermined:open): PVS-studio big list of errors

[FFmpeg]

#8156: PVS-studio big list of errors
-------------------------------------+-------------------------------------
             Reporter:  Balling      |                    Owner:
                 Type:  defect       |                   Status:  open
             Priority:  normal       |                Component:
                                     |  undetermined
              Version:  unspecified  |               Resolution:
             Keywords:               |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------

Comment (by Balling):

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/avf_showfreqs.c#L198
 This should be if (!s->avg_data)

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/window_func.h#L136
 Wow, what is the point? norm = norm?

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/af_afir.c#L565


 s->eof_coeffs is always true because were it false we would have already
 return on line 561.

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/avf_showspectrum.c#L1064
 This !!s->stop should be just 1))

 {{{
 ./libavfilter/f_loop.c  187     warn    V728 An excessive check can be
 simplified. The '||' operator is surrounded by opposite expressions
 's->nb_samples < s->size' and 's->nb_samples >= s->size'.
 ./libavfilter/f_loop.c  381     warn    V728 An excessive check can be
 simplified. The '||' operator is surrounded by opposite expressions
 's->nb_frames < s->size' and 's->nb_frames >= s->size'.

 }}}

 These were in first comment...

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/src_movie.c#L259
 timestamp > 0 is always true because timestamp = movie->seek_point; which
 is > 0

 Wow, so many false positives((

--
Ticket URL: <https://trac.ffmpeg.org/ticket/8156#comment:5>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker